Many of us write opensource code in a void: nobody ever looks at it, uses it nor reviews it. We are the only users and authors.

In order to improve, where can we get our code reviewed? I don’t mean professionally, just from like-minded individuals.

  • lhamil64@programming.dev
    link
    fedilink
    arrow-up
    9
    ·
    11 months ago

    One issue I can see with the points system is that people could just approve it with a “Looks good to me!” without even looking at the code. Or just looking at a small portion of the code.

    • coloredgrayscale@programming.dev
      link
      fedilink
      arrow-up
      4
      ·
      11 months ago

      Also bike shedding. Simple stuff may get many people willing to review / argue about how you should have used A over B, or even C

      Big / complicated projects - forget it. Especially if if they would need major refactoring.

      • kassuro@feddit.de
        link
        fedilink
        arrow-up
        3
        ·
        11 months ago

        But who decides that? If the person who requested it can do this, you only need a friend to abuse the system and give each other a few extra points.

        Maybe a open point history could help with this and users moderate themselves with this.

    • kassuro@feddit.de
      link
      fedilink
      arrow-up
      1
      ·
      11 months ago

      Yeah that’s definitely a possibility. It’s really a tricky topic to build a review community. One could try other approaches like dedicated volunteer reviewers. But if you look at exorcism, that will become hard to manage for languages with huge demand.

      A system where everyone also needs to review is definitely better. Especially since everyone also learns reading other peoples code.